Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement delete of a resource #1800

Merged
merged 7 commits into from
Oct 12, 2023
Merged

Implement delete of a resource #1800

merged 7 commits into from
Oct 12, 2023

Conversation

1101-1
Copy link
Collaborator

@1101-1 1101-1 commented Oct 11, 2023

Description

Resource deletion was implemented:

  1. Implementation of Generic Delete Resource Function:

    • Implemented a generic delete resource method that can be utilized for deleting Azure resources

  2. Update to AzureResource for Resource Deletion:

    • Integrated the generic delete resource method into the Azure Resource class, enabling deletion of resources by retrieving the client and invoking the delete by id resource method

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with tox
  • Adjust AzureClient and implement a generic delete resource method
  • Implement delete in AzureResource by retrieving the client and calling the delete resource method.

@1101-1 1101-1 changed the title Implement delete of a resource. Implement delete of a resource Oct 11, 2023
aquamatthias
aquamatthias reviewed Oct 11, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my comments.

plugins/azure/resoto_plugin_azure/resource/base.py Outdated Show resolved Hide resolved
plugins/azure/resoto_plugin_azure/azure_client.py Outdated Show resolved Hide resolved
aquamatthias
aquamatthias previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

@1101-1 1101-1 force-pushed the delete_resource branch 2 times, most recently from 34a4d1c to 306ba6b Compare October 12, 2023 12:27
@aquamatthias aquamatthias merged commit df75df0 into someengineering:main Oct 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

@meln1k meln1k Awaiting requested review from meln1k meln1k is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1101-1 @aquamatthias