Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the name discovery, event delivery and resurce_collected bugs #159

Merged
merged 21 commits into from
Nov 16, 2023
Merged

Fix the name discovery, event delivery and resurce_collected bugs #159

merged 21 commits into from
Nov 16, 2023

Conversation

meln1k
Copy link
Member

@meln1k meln1k commented Nov 16, 2023

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with nox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@meln1k meln1k changed the title add more logging Fix the name discovery, event delivery and resurce_collected bugs Nov 16, 2023
@meln1k meln1k marked this pull request as ready for review November 16, 2023 17:22
aquamatthias
aquamatthias approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meln1k meln1k merged commit 4a49b68 into main Nov 16, 2023
2 checks passed
@meln1k meln1k deleted the nm/fix-domain-event-subscriber branch November 16, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meln1k @aquamatthias