Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HashUnique into its own package and file #27

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Move HashUnique into its own package and file #27

merged 3 commits into from
Jun 27, 2024

Conversation

tjons
Copy link
Contributor

@tjons tjons commented Jun 27, 2024 •
edited
Loading

Reorganize code added in #24, #25 and #26 so that the unique hashing functionality is in its own package and the outputs are in their own file for better diffability.

@tjons tjons changed the title Move HashUnique into it's own package and file Move HashUnique into its own package and file Jun 27, 2024
marcogschmidt
marcogschmidt approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@marcogschmidt marcogschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the HEAD of this branch with master before we started making any of the recent hash-related changes and the diff looks good.

@marcogschmidt marcogschmidt merged commit df7140b into master Jun 27, 2024
1 check passed
@marcogschmidt marcogschmidt deleted the tjons/unique-hash-own-file branch June 27, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcogschmidt marcogschmidt marcogschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjons @marcogschmidt