Fixed determining Boolean from false
#378
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small hack, that fixes incorrect behaviour in #377.
The problem, as I see it, is that
Virtus::Attribute::Boolean
has onlyTrueClass
as a primitive. This makesVirtus::TypeLookup
to determine correctly onlytrue
, because it executesTrueClass >= true.class
. The same expression withfalse
-TrueClass >= false.class
will not allow TypeLookup to think that false is somehow connected to Virtus::Attribute::Boolean.I replaced TrueClass primitive with BooleanPrimitive, that returns
true
when comparing with both TrueClass and FalseClass, thus allowing TypeLookup to connecttrue
andfalse
values withVirtus::Attribute::Boolean
.