Add Rails 7.2 support #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 95.98% 95.97% -0.01%
==========================================
Files 207 207
Lines 4878 4866 -12
==========================================
- Hits 4682 4670 -12
Misses 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3 tasks
|
We need this for solidusio/solidus#5843 but it only will pass tests if we also merge the solidus PR. I think we should merge this first and then allow it to fail until we also merge the solidus PR /c @solidusio/core-team |
jarednorman
approved these changes
Oct 31, 2024
and test 3.3 instead. Rails 7.2 does not support Ruby 3.0 anymore and it is out of support anyway.
Rails will complain that we have setup the sandbox database in development environment, so we need to reset the db env to test.
jarednorman
approved these changes
Nov 4, 2024
It is easier to debug which ruby and rails versions we are running with.
|
@tvdeyen this is not needed anymore? |
Not sure. It adds specs for Rails 7.2 |
|
@tvdeyen can be closed at this point or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now we need the master branch of canonical-rails and my solidus fork with the rails-7.2 branch.
Summary
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: