Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Spree::Money autoloadable #6040

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

Make Spree::Money autoloadable #6040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ Layout/SpaceAroundOperators:
- "backend/spec/features/admin/orders/order_details_spec.rb"
- "bin/__rspec"
- "bin/rspec"
- "core/lib/spree/money.rb"
- "core/app/models/spree/money.rb"
- "core/spec/models/spree/order/number_generator_spec.rb"

# Offense count: 8
Expand Down Expand Up @@ -413,7 +413,7 @@ Rails/OutputSafety:
- "core/app/helpers/spree/base_helper.rb"
- "core/app/helpers/spree/checkout_helper.rb"
- "core/app/helpers/spree/products_helper.rb"
- "core/lib/spree/money.rb"
- "core/app/models/spree/money.rb"

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Expand Down
0 core/lib/spree/money.rb → core/app/models/spree/money.rb
View file
Open in desktop
File renamed without changes.
1 change: 0 additions & 1 deletion core/lib/spree/core.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ class GatewayError < RuntimeError; end

require 'spree/i18n'
require 'spree/localized_number'
require 'spree/money'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add a file with a deprecation warning, like we did in #6056 and friends.

require 'spree/permitted_attributes'

require 'spree/core/importer'
Expand Down
0 core/spec/lib/spree/money_spec.rb → core/spec/models/spree/money_spec.rb
View file
Open in desktop
File renamed without changes.
Loading