[Admin][Users] Add new admin store credits edit_memo flow #6033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec was becoming really long, and since store credit actions get their own controller and their own request specs, it makes sense to break these out into their own feature spec too. Now if one case fails we don't have to re-run this entire enormous user spec.
MadelineCollier
changed the title
MadelineCollier
force-pushed
the
admin-user-store-credit-refactor
branch
from
9f8a0a5 to
60e4bfc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6033 +/- ##
=======================================
Coverage 87.82% 87.82%
=======================================
Files 477 477
Lines 11670 11670
=======================================
Hits 10249 10249
Misses 1421 1421 ☔ View full report in Codecov by Sentry. |
MadelineCollier
force-pushed
the
admin-user-store-credit-refactor
branch
from
60e4bfc to
9639966
Compare
This should get us to 100% coverage for the StoreCreditsController!
|
@MadelineCollier Given the lack of humor in this repo I would like to mention that I am Cattown person and not a dogtown person |
kennyadsl
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for issue: #5824
The store credits flow is in the process of being significantly refactored so this is only part of the edit flow. My original plan was to use one modal for the edit_amount and edit_memo flow, but since amount has really specific validations and constraints, and it requires that a
StoreCreditReasonbe given for each change, it made sense to build it as a separate flow. Memo, by contrast, has basically no constraints and it can be as long as the database can hold, and even empty if desired. It also doesn't require a reason for changes. The conditional logic was getting really spaghetti in the controller action so it made sense to go back to the old solidus_backend flow of having two separate edit flows. Now with the fancy new admin UI. Again, no designs so I did my best.Screenshots
Screen.Recording.2024-12-12.at.10.39.33.AM.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: