[Admin][Users] Add new admin store credits edit_amount flow #6031
+333
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, as part of a form, you might want to include a field for something which is not strictly part of the object you are updating. In this instance it was a form for updating a StoreCredit, which needed to include a select for a StoreCreditReason id. Since StoreCreditReason is only linked to StoreCredit via a StoreCreditEvent, this select was blowing up when we tried to use it (due to trying to call store_credit.public_send(store_credit_reason_id) which is not defined). This extra check allows this form field to be used more freely and flexibly without immediately blowing up.
MadelineCollier
changed the title
MadelineCollier
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6031 +/- ##
==========================================
+ Coverage 89.51% 89.54% +0.02%
==========================================
Files 787 788 +1
Lines 18120 18174 +54
==========================================
+ Hits 16220 16273 +53
- Misses 1900 1901 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is for issue: #5824
The store credits flow is in the process of being significantly refactored so this is only part of the edit flow. It was a bit of a nightmare to get working but it's finally there, with error messages and all the different turbo refreshes working as desired. The path stays the same throughout. Again, no designs, so I did my best.
Screenshots
Screen.Recording.2024-12-11.at.5.21.21.PM.mov