Skip to content

Commit

Permalink
Do not use solidus_frontend to test extension test app generator
Browse files Browse the repository at this point in the history
solidus_frontend is [EOL since 2024-10-21](https://github.com/solidusio/solidus_frontend?tab=readme-ov-file#-warning)
using it to test the extension:test_app rake task is not working since
it is not compatible with latest Rails, Ruby and Solidus.

Since we already have a test for the extension test app generator we
can check for it's dummy app existence instead.
  • Loading branch information
tvdeyen committed Oct 29, 2024
1 parent 0a9b182 commit 8c88405
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,12 +279,10 @@ jobs:
- test_page:
expected_text: "<title>Sample Store</title>"
- install_dummy_app
- install_dummy_app:
extra_gems: "solidus_frontend"
- run:
name: "Ensure solidus_frontend installer is run"
name: "Ensure extension test app is created"
command: |
test -f /tmp/dummy_extension/spec/dummy/config/initializers/solidus_frontend.rb
test -d /tmp/dummy_extension/spec/dummy
test_solidus:
parameters:
Expand Down

0 comments on commit 8c88405

Please sign in to comment.