Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preload.mdx - missing word #913

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

klequis
Copy link
Contributor

@klequis klequis commented Oct 7, 2024

was: that can used

new: that can be used

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

Related issues & labels

  • Closes #
  • Suggested label(s) (optional):

was: that can used

new: that can be used
Copy link

stackblitz bot commented Oct 7, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 79b30f2
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/670450ad4c63590008e7055c
😎 Deploy Preview https://deploy-preview-913--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes
Copy link
Member

@klequis Before we can merge this can you please ensure you have checked off the requirements at the top of the PR template.

@klequis
Copy link
Contributor Author

klequis commented Oct 8, 2024

"This PR references an issue (except for typos, broken links, or other minor problems)"

Is this not the way to address typos?

@LadyBluenotes
Copy link
Member

"This PR references an issue (except for typos, broken links, or other minor problems)"

Is this not the way to address typos?

The checkboxes were not marked, which suggests that the they were not addressed. That's what I was referring to.

Thank you for checking them off.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) October 8, 2024 17:31
@LadyBluenotes LadyBluenotes merged commit ac1d02b into solidjs:main Oct 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants