Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config based routing #908

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

brenelz
Copy link
Collaborator

@brenelz brenelz commented Oct 1, 2024

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

The components in the examples need to be lazy or at least a functino that returns JSX

Related issues & labels

Copy link

stackblitz bot commented Oct 1, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit c55b006
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/66fb4aca3170720008aee258
😎 Deploy Preview https://deploy-preview-908--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 142c567
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/66fb4ad0dc69d900081f476d
😎 Deploy Preview https://deploy-preview-908--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LadyBluenotes LadyBluenotes enabled auto-merge (squash) October 3, 2024 15:51
@LadyBluenotes LadyBluenotes merged commit 3dd5613 into solidjs:main Oct 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic imports should have lazy() on Router example snippets
2 participants