Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createEvent and createSubject #707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

devagrawal09
Copy link

Adds solid-events as a primitive.

Copy link

changeset-bot bot commented Oct 14, 2024

⚠️ No Changeset found

Latest commit: 378567e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@atk
Copy link
Member

atk commented Oct 14, 2024

The name events easily lends itself to confusion with UI Events. What you implement here is a message bus, not an event system.

@thetarnav
Copy link
Member

This should be extending the event-bus package
I don’t want to have two packages for the same problem.

@thetarnav
Copy link
Member

thetarnav commented Oct 14, 2024

Why does this depend on rxjs? Shouldn’t it only implement the same interface to be usable with it?
Or it should be made explicit that it’s a wrapper around rxjs

@devagrawal09
Copy link
Author

Why does this depend on rxjs

The rxjs dependency is temporary, I'll work on getting rid of that soon

This should be extending the event-bus package
I don’t want to have two packages for the same problem.

Fair, this is mostly a separate primitive because it's a solidhack submission, if this makes more sense as an extension to event-bus I'm happy to contribute.
I'll spend some time next week rewriting the internals to use event bus instead of rxjs. Would love to hear your ideas around what the api should look like if this were to be an extension to event-bus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants