Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite build script to build all packages in one process (Removes CJS) #701

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

thetarnav
Copy link
Member

Rewrites build script to build all packages in one process
Similarly to how testing works
So no turborepo cashing, but it's much faster overall
5s to build all packages instead of a couple of minutes
So should be much easier for new people to fork and build locally and not have to wait so much
Also website deploys could happen on main now as the netlify build should be a lot faster

Proper turbo-like caching could be added later as well and be used for tests too, without sacrificing the time to build all packages.

Please run rm -rf packages/*/dist/* and rm -rf .turbo to clear old outputs

This also removes CJS support

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: 30949cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 82 packages
Name Type
@solid-primitives/intersection-observer Minor
@solid-primitives/broadcast-channel Minor
@solid-primitives/mutation-observer Minor
@solid-primitives/controlled-props Minor
@solid-primitives/event-dispatcher Minor
@solid-primitives/transition-group Minor
@solid-primitives/page-visibility Minor
@solid-primitives/resize-observer Minor
@solid-primitives/signal-builders Minor
@solid-primitives/active-element Minor
@solid-primitives/event-listener Minor
@solid-primitives/jsx-tokenizer Minor
@solid-primitives/script-loader Minor
@solid-primitives/state-machine Minor
@solid-primitives/connectivity Minor
@solid-primitives/static-store Minor
@solid-primitives/destructure Minor
@solid-primitives/event-props Minor
@solid-primitives/geolocation Minor
@solid-primitives/filesystem Minor
@solid-primitives/flux-store Minor
@solid-primitives/fullscreen Minor
@solid-primitives/input-mask Minor
@solid-primitives/pagination Minor
@solid-primitives/permission Minor
@solid-primitives/analytics Minor
@solid-primitives/autofocus Minor
@solid-primitives/clipboard Minor
@solid-primitives/event-bus Minor
@solid-primitives/immutable Minor
@solid-primitives/lifecycle Minor
@solid-primitives/scheduled Minor
@solid-primitives/selection Minor
@solid-primitives/websocket Minor
@solid-primitives/gestures Minor
@solid-primitives/keyboard Minor
@solid-primitives/platform Minor
@solid-primitives/presence Minor
@solid-primitives/resource Minor
@solid-primitives/rootless Minor
@solid-primitives/context Minor
@solid-primitives/devices Minor
@solid-primitives/graphql Minor
@solid-primitives/history Minor
@solid-primitives/masonry Minor
@solid-primitives/mutable Minor
@solid-primitives/pointer Minor
@solid-primitives/promise Minor
@solid-primitives/storage Minor
@solid-primitives/trigger Minor
@solid-primitives/virtual Minor
@solid-primitives/workers Minor
@solid-primitives/bounds Minor
@solid-primitives/cursor Minor
@solid-primitives/marker Minor
@solid-primitives/scroll Minor
@solid-primitives/spring Minor
@solid-primitives/stream Minor
@solid-primitives/styles Minor
@solid-primitives/upload Minor
@solid-primitives/audio Minor
@solid-primitives/fetch Minor
@solid-primitives/keyed Minor
@solid-primitives/media Minor
@solid-primitives/mouse Minor
@solid-primitives/props Minor
@solid-primitives/range Minor
@solid-primitives/share Minor
@solid-primitives/start Minor
@solid-primitives/timer Minor
@solid-primitives/tween Minor
@solid-primitives/utils Minor
@solid-primitives/date Minor
@solid-primitives/deep Minor
@solid-primitives/i18n Minor
@solid-primitives/idle Minor
@solid-primitives/list Minor
@solid-primitives/memo Minor
@solid-primitives/refs Minor
@solid-primitives/map Minor
@solid-primitives/raf Minor
@solid-primitives/set Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atk
Copy link
Member

atk commented Sep 29, 2024

Since the removal of CJS support might be considered a breaking change, shouldn't this be a major update? Minor breaking changes are a violation of semver.

Also, in CONTRIBUTING.md, the design maxim number 12 still includes CJS support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants