Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing user props through #72

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

thetarnav
Copy link
Member

@thetarnav thetarnav commented Sep 1, 2022

Fixes #69

createFocusable, createButton and createToggleButton should pass user props back with the returned props object.
I'm guessing that this is the way all of the primitives should work, but if not, let me know.

TODO:

  • fix createRadio tests
  • fix createSwitch

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

🦋 Changeset detected

Latest commit: 0dfc903

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@solid-aria/button Patch
@solid-aria/focus Patch
@solid-aria/textfield Patch
@solid-aria/primitives Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thetarnav thetarnav linked an issue Sep 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createButton isn't passing user props to the element
1 participant