Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix closing http response body #8

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Fix closing http response body #8

merged 3 commits into from
Jul 3, 2024

Conversation

jskiba
Copy link
Contributor

@jskiba jskiba commented Jul 3, 2024 •
edited
Loading

  • http response body was never closed because it was called inside for loop

@jskiba jskiba merged commit af593d6 into main Jul 3, 2024
2 checks passed
@jskiba jskiba deleted the fix-defer-in-for-loop branch July 3, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArkadiuszNitkaSWI ArkadiuszNitkaSWI ArkadiuszNitkaSWI approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jskiba @ArkadiuszNitkaSWI