Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prerelease #80

Merged
merged 1 commit into from
Aug 24, 2023
Merged

New prerelease #80

merged 1 commit into from
Aug 24, 2023

Conversation

raphael-theriault-swi
Copy link
Member

@raphael-theriault-swi raphael-theriault-swi commented Aug 24, 2023

Mostly so I can test the proxy on both this library and the legacy on at the same time tomorrow

@solarwinds-apm/bindings 1.0.0-pre.2, @solarwinds-apm/compat 1.0.0-pre.2, @solarwinds-apm/dependencies 1.0.0-pre.2, @solarwinds-apm/eslint-config 1.0.0-pre.2, @solarwinds-apm/histogram 1.0.0-pre.2, @solarwinds-apm/lazy 1.0.0-pre.2, @solarwinds-apm/merged-config 1.0.0-pre.2, @solarwinds-apm/sdk 1.0.0-pre.2, @solarwinds-apm/test 1.0.0-pre.1, solarwinds-apm 14.0.0-pre.2

@solarwinds-apm/bindings 1.0.0-pre.2, @solarwinds-apm/compat 1.0.0-pre.2, @solarwinds-apm/dependencies 1.0.0-pre.2, @solarwinds-apm/eslint-config 1.0.0-pre.2, @solarwinds-apm/histogram 1.0.0-pre.2, @solarwinds-apm/lazy 1.0.0-pre.2, @solarwinds-apm/merged-config 1.0.0-pre.2, @solarwinds-apm/sdk 1.0.0-pre.2, @solarwinds-apm/test 1.0.0-pre.1, solarwinds-apm 14.0.0-pre.2
@raphael-theriault-swi raphael-theriault-swi marked this pull request as ready for review August 24, 2023 23:29
@raphael-theriault-swi raphael-theriault-swi requested a review from a team August 24, 2023 23:29
@@ -1,6 +1,6 @@
{
"name": "@solarwinds-apm/test",
"version": "0.0.0",
"version": "1.0.0-pre.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be 1.0.0-pre.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package didn't exist last time so no !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions are currently pretty in sync but over time they might not be, which is voluntary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, got it!

Copy link

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Raph!

@raphael-theriault-swi raphael-theriault-swi merged commit 2fcae93 into main Aug 24, 2023
34 of 35 checks passed
@raphael-theriault-swi raphael-theriault-swi deleted the release-2023-08-24 branch August 24, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants