Skip to content

Commit

Permalink
actually fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
raphael-theriault-swi committed Nov 20, 2023
1 parent 75c80f9 commit d8d3647
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions packages/compat/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"@opentelemetry/api": "^1.3.0",
"@opentelemetry/sdk-trace-base": "~1.18.1",
"@opentelemetry/sdk-trace-node": "~1.18.1",
"@opentelemetry/semantic-conventions": "~1.18.1",
"@solarwinds-apm/eslint-config": "workspace:^",
"@solarwinds-apm/rollup-config": "workspace:^",
"@solarwinds-apm/test": "workspace:^",
Expand Down
15 changes: 12 additions & 3 deletions packages/compat/test/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,10 @@ describe("instrument", () => {
code: SpanStatusCode.ERROR,
message: "error",
})
expect(span?.attributes).to.have.property(
expect(span?.events[0]!.attributes).to.include({
[SemanticAttributes.EXCEPTION_MESSAGE]: "error",
})
expect(span?.events[0]!.attributes).to.have.property(
SemanticAttributes.EXCEPTION_STACKTRACE,
)
})
Expand Down Expand Up @@ -151,7 +154,10 @@ describe("instrument", () => {
code: SpanStatusCode.ERROR,
message: "error",
})
expect(span?.attributes).to.have.property(
expect(span?.events[0]!.attributes).to.include({
[SemanticAttributes.EXCEPTION_MESSAGE]: "error",
})
expect(span?.events[0]!.attributes).to.have.property(
SemanticAttributes.EXCEPTION_STACKTRACE,
)
})
Expand Down Expand Up @@ -247,7 +253,10 @@ describe("pInstrument", () => {
code: SpanStatusCode.ERROR,
message: "error",
})
expect(span?.attributes).to.have.property(
expect(span?.events[0]!.attributes).to.include({
[SemanticAttributes.EXCEPTION_MESSAGE]: "error",
})
expect(span?.events[0]!.attributes).to.have.property(
SemanticAttributes.EXCEPTION_STACKTRACE,
)
})
Expand Down
1 change: 1 addition & 0 deletions yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d8d3647

Please sign in to comment.