Refactor - Shuffle register assignment in JIT #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/shuffle_registers
branch
2 times, most recently
from
b7b5392 to
bcbf14c
Compare
Lichtso
force-pushed
the
refactor/shuffle_registers
branch
from
bcbf14c to
ccb81e5
Compare
Lichtso
force-pushed
the
refactor/shuffle_registers
branch
from
ccb81e5 to
bb34253
Compare
LucasSte
reviewed
Oct 1, 2024
| @@ -112,27 +112,29 @@ impl JitProgram { | |||
| "push rbx", | |||
| "push rbp", | |||
| "mov [{host_stack_pointer}], rsp", | |||
| "add QWORD PTR [{host_stack_pointer}], -8", // We will push RIP in "call r10" later | |||
| "mov rbx, rax", | |||
| "add QWORD PTR [{host_stack_pointer}], -8", | |||
There was a problem hiding this comment.
Is this equivalent to add QWORD PTR [{host_stack_pointer}], -8(%rsp)?
rsp is the top of the stack, but we are offsetting outside the stack area, aren't we?
There was a problem hiding this comment.
Ah, this is Intel ASM. I was trying to understand this as AT&T ASM.
LucasSte
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.