Cleanup - reject_callx_r10
#598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
cleanup/reject_callx_r10
branch
2 times, most recently
from
b6d0820 to
820e8c7
Compare
Lichtso
force-pushed
the
cleanup/reject_callx_r10
branch
from
820e8c7 to
1a0a9aa
Compare
LucasSte
reviewed
Sep 26, 2024
| @@ -221,7 +220,7 @@ pub struct RequisiteVerifier {} | |||
| impl Verifier for RequisiteVerifier { | |||
| /// Check the program against the verifier's rules | |||
| #[rustfmt::skip] | |||
| fn verify<C: ContextObject>(prog: &[u8], config: &Config, sbpf_version: &SBPFVersion, function_registry: &FunctionRegistry<usize>, syscall_registry: &FunctionRegistry<BuiltinFunction<C>>) -> Result<(), VerifierError> { | |||
| fn verify<C: ContextObject>(prog: &[u8], _config: &Config, sbpf_version: &SBPFVersion, function_registry: &FunctionRegistry<usize>, syscall_registry: &FunctionRegistry<BuiltinFunction<C>>) -> Result<(), VerifierError> { | |||
There was a problem hiding this comment.
Perhaps we could remove the unused argument from the trait?
There was a problem hiding this comment.
It is likely that there will be more feature flags affecting the verifier in the future. And this would have to be removed / added to the interface on the validator side every time.
LucasSte
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.