Refactor - removes usage of REGISTER_OTHER_SCRATCH
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/argument_register_indirect_rsp
branch
from
350d954 to
0628d68
Compare
LucasSte
reviewed
Sep 26, 2024
| @@ -1554,7 +1556,7 @@ impl<'a, C: ContextObject> JitCompiler<'a, C> { | |||
| }; | |||
| self.emit_rust_call(Value::Constant64(store, false), &[ | |||
| Argument { index: 3, value: Value::Register(REGISTER_SCRATCH) }, // Specify first as the src register could be overwritten by other arguments | |||
| Argument { index: 2, value: Value::Register(REGISTER_OTHER_SCRATCH) }, | |||
| Argument { index: 2, value: Value::RegisterIndirect(RSP, -8, false) }, | |||
There was a problem hiding this comment.
Shouldn't the offset for stack_slot_of_value_to_store (i.e. -112) be the same as the one here (-8)?
There was a problem hiding this comment.
At this point the start of emit_rust_call has already saved all the VM register state, thus the stack is taller. RSP-8 is pointing to the next stack slot to be pushed. This is where we temporarily saved the "value to store" at. It will be overwritten by the RIP in the subsequent call in the end of emit_rust_call.
…ck_slot_of_value_to_store.
Lichtso
force-pushed
the
refactor/argument_register_indirect_rsp
branch
from
0628d68 to
8c5e9a9
Compare
LucasSte
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the machinecode emitted for: