Refactor - reduce usage of REGISTER_OTHER_SCRATCH
#596
+53
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NAL_FUNCTION_CALL_PROLOGUE.
…AL_FUNCTION_CALL_REG.
LucasSte
reviewed
Sep 26, 2024
| self.emit_ins(X86Instruction::store(OperandSize::S64, REGISTER_MAP[0], REGISTER_OTHER_SCRATCH, X86IndirectAccess::Offset(std::mem::size_of::<u64>() as i32))); // result.return_value = R0; | ||
| self.emit_ins(X86Instruction::load_immediate(OperandSize::S64, REGISTER_MAP[0], 0)); | ||
| if self.config.enable_instruction_meter { | ||
| self.emit_ins(X86Instruction::alu(OperandSize::S64, 0x29, REGISTER_SCRATCH, REGISTER_INSTRUCTION_METER, 0, None)); // REGISTER_INSTRUCTION_METER -= pc; |
There was a problem hiding this comment.
This operation is re-emitted in ANCHOR_EXIT, even though REGISTER_SCRATCH is zero.
There was a problem hiding this comment.
I haven't checked the other PR for removing REGISTER_OTHER_SCRATCH yet, so, please, ignore this comment if this is solved there.
There was a problem hiding this comment.
You mean the code for the instruction metering is redundant to that in ANCHOR_EPILOGUE, which is on purpose. Because REGISTER_SCRATCH is clobbered here and then zeroed out so that it is not double metered later.
LucasSte
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the machinecode emitted for: