Check if syscall is valid during verification #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
reviewed
Sep 5, 2024
LucasSte
force-pushed
the
check-syscall
branch
from
44f33fc to
2923843
Compare
Lichtso
reviewed
Sep 5, 2024
LucasSte
force-pushed
the
check-syscall
branch
from
2923843 to
e848b5b
Compare
LucasSte
force-pushed
the
check-syscall
branch
from
045d7a6 to
27ceb7d
Compare
Lichtso
reviewed
Sep 5, 2024
Lichtso
reviewed
Sep 5, 2024
Lichtso
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon the activation of static syscalls, we'll no longer emit errors when a program contains an unknown syscall. This PR modifies the verifier so that we error out when this is the case.