Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup - Removes ELF_INSN_DUMP_OFFSET #541

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Oct 9, 2023

Fixes #539

@Lichtso Lichtso requested a review from dmakarov October 9, 2023 08:50
@codecov-commenter
Copy link

Codecov Report

Merging #541 (c46990b) into main (06e22d7) will decrease coverage by 0.02%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   88.43%   88.41%   -0.02%     
==========================================
  Files          24       24              
  Lines       10275    10259      -16     
==========================================
- Hits         9087     9071      -16     
  Misses       1188     1188              
Files Coverage Δ
src/ebpf.rs 79.59% <ø> (ø)
src/elf.rs 87.61% <100.00%> (-0.07%) ⬇️
src/static_analysis.rs 65.82% <0.00%> (ø)
src/verifier.rs 97.93% <91.66%> (-0.08%) ⬇️

@ksolana
Copy link

ksolana commented Oct 9, 2023

should we add test case from #539 or the existing tests cover it already?

@Lichtso
Copy link
Author

Lichtso commented Oct 10, 2023

This does not change the behavior / functionality. It is purely a cosmetic change. And there are lots of tests which were adjusted, all had the display offset removed. So I would say there is plenty of coverage.

@Lichtso Lichtso merged commit ae90876 into main Oct 10, 2023
12 checks passed
@Lichtso Lichtso deleted the cleanup/pc_display_offset branch October 10, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call instruction transfers control to incorrect address
4 participants