forked from qmonnet/rbpf
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error message when elf_parser fails on long section names #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolana
force-pushed
the
main
branch
2 times, most recently
from
October 2, 2023 02:08
97858e2
to
8d9b4fe
Compare
ksolana
commented
Oct 2, 2023
Lichtso
reviewed
Oct 2, 2023
ksolana
force-pushed
the
main
branch
2 times, most recently
from
October 3, 2023 04:57
f670208
to
0f66f0f
Compare
Codecov Report
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 24 24
Lines 10258 10264 +6
==========================================
+ Hits 9070 9075 +5
- Misses 1188 1189 +1
|
let me know if it is okay to merge the patch. |
dmakarov
reviewed
Oct 4, 2023
lgtm, but maybe confirm @Lichtso approves before merging. |
Took the liberty to push the following changes:
|
Lichtso
approved these changes
Oct 6, 2023
Resolve #532 |
Thanks! looks better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #532
With the patch error message now looks like: