Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Stops using assign for results as that drops the previously (non) existing value #513

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Sep 12, 2023

Further refactoring of the Error structure and its allocation is planned.

Credit for finding this goes to @alessandrod.

@codecov-commenter
Copy link

Codecov Report

Merging #513 (90b2b99) into main (c001c6c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          23       23           
  Lines       10301    10301           
=======================================
  Hits         9233     9233           
  Misses       1068     1068           
Files Changed Coverage Δ
src/jit.rs 92.36% <100.00%> (ø)

@Lichtso Lichtso merged commit e7aaea2 into main Sep 12, 2023
12 checks passed
@Lichtso Lichtso deleted the fix/jit_program_result branch September 12, 2023 20:03
Lichtso added a commit that referenced this pull request Sep 19, 2023
* Adds error message in case std::alloc::alloc() fails. (#505)

* Stops using assign as that drops the previously (non) existing value. (#513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants