Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

feat: tds scoring and api implementation #527

Merged
merged 2 commits into from
Oct 15, 2019
Merged

feat: tds scoring and api implementation #527

merged 2 commits into from
Oct 15, 2019

Conversation

sunnygleason
Copy link
Contributor

Problem:

  • the current bikes don't race 😞

Solution:

  • implement the race position function as: blockBasedPosition + stakeBasedAdjustment 🚲
  • since it's so hard to test, put in a demo mode for the meantime so folks can check out the mechanics 🐎

@sunnygleason
Copy link
Contributor Author

This was referenced Oct 10, 2019
Closed
Open
Open
@sunnygleason
Copy link
Contributor Author

(ugh commit lint)

@sunnygleason sunnygleason mentioned this pull request Oct 10, 2019
Open
@sunnygleason sunnygleason changed the title feat: TdS scoring and API implementation feat: tds scoring and api implementation Oct 10, 2019
@manuel-calavera
Copy link
Contributor

@sunnygleason thanks for moving it!

CriesofCarrots
CriesofCarrots previously approved these changes Oct 11, 2019
View reviewed changes
Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits.
Otherwise lgtm, although I haven't spun it up yet to see it in action.

src/v2/constants.js Show resolved Hide resolved
api/views/tourdesol/index.js Outdated Show resolved Hide resolved
src/v2/components/TourDeSol/Cards/index.jsx Show resolved Hide resolved
@manuel-calavera manuel-calavera mentioned this pull request Oct 14, 2019
Merged
@mergify mergify bot dismissed stale reviews from manuel-calavera and CriesofCarrots October 15, 2019 14:46

Pull request has been modified.

@sunnygleason sunnygleason merged commit d35a016 into solana-labs:master Oct 15, 2019
@sunnygleason sunnygleason deleted the tds-impl branch October 15, 2019 14:52
@mvines
Copy link
Contributor

mvines commented Oct 15, 2019

🎉 This PR is included in version 1.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sunnygleason
Copy link
Contributor Author

FYI this requires a JS client library update to become visible on edge w/ the rootSlot change

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manuel-calavera manuel-calavera manuel-calavera left review comments

@CriesofCarrots CriesofCarrots CriesofCarrots left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnygleason @manuel-calavera @mvines @CriesofCarrots