Skip to content
This repository has been archived by the owner on Jul 22, 2020. It is now read-only.

fix: sanitize usernames #513

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

sunnygleason
Copy link
Contributor

Problem:

  • icky usernames are failing the whole batch Keybase lookup

Solution:

  • sanitize keybase usernames (imperfect but at least a first line of defense)

@sunnygleason
Copy link
Contributor Author

fixes #452 (hopefully) 😂

api/api.js Outdated Show resolved Hide resolved
Copy link
Member

@jstarry jstarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a few tests as well!

@sunnygleason
Copy link
Contributor Author

It would be nice to have a few tests as well!

I heartily agree! If possible, I would like to land this ahead of implementing testing infrastructure, and have created tracking ticket #515 for that work...

...And maybe I can even recruit you for some of those initial tests, since this is code I originally landed from someone you know... 😉 🍻 😂

CriesofCarrots
CriesofCarrots previously approved these changes Oct 7, 2019
Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@mergify mergify bot dismissed CriesofCarrots’s stale review October 8, 2019 16:25

Pull request has been modified.

@sunnygleason sunnygleason merged commit 8e6e711 into solana-labs:master Oct 8, 2019
@sunnygleason sunnygleason deleted the keybase-sanitize branch October 8, 2019 16:27
@mvines
Copy link
Member

mvines commented Oct 8, 2019

🎉 This PR is included in version 1.59.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mvines mvines added the released label Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants