SIMD-0166: SBPF Dynamic stack frames #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
changed the title
ravyu-jump
reviewed
Sep 2, 2024
LucasSte
changed the title
0x0ece
approved these changes
Nov 22, 2024
| call convention obviates the need to use R5 for retrieving the caller’s frame | ||
| pointer address to access those parameters. | ||
|
|
||
| ### Changes in the verifier |
There was a problem hiding this comment.
I would simplify this section. ATM it seems to describe the whole process of validating registers, not just the changes due to this SIMD.
The verifier should include a new rule to accept R11 as a destination register under the following conditions:
- Dynamic stack frames are enabled
- The corresponding instruction is
add64_imm(opcode0x07) - The corresponding value of
immis a multiple of the alignment (i.e. multiple of 64).
There was a problem hiding this comment.
As a comment to my comment :) Based on the current code, I'd simply add an extra "and" to the "if" condition that returns Ok() for R11. Therefore I don't think we need an error for alignment. Either R11 is allowed (if all 3 conditions pass), or it's not.
There was a problem hiding this comment.
I re-wrote the section, based on the new design we devised with only R10.
0x0ece
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.