-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basics/processing-instructions/poseidon #285
Added basics/processing-instructions/poseidon #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission! To verify the technical implementation, please complete these steps:
- Merge the main branch into your PR to get the latest updates
- Run
pnpm fix
at the project root for consistent code style - Ensure your implementation includes:
- Transpiled Anchor program in the
programs
folder - TypeScript files in the
ts-programs
folder
- Transpiled Anchor program in the
- Run
poseidon sync
to synchronize program ID and keys - Run
cargo fmt
andcargo clippy
for Rust code quality - Push your changes
Please note: This review is to verify technical completeness of the submission
Let me know once you've completed these steps and I'll review again. Thanks!
gm @heyAyushh , I've completed the requested steps:
Please review again. Thank you! |
gm @heyAyushh , I have refactored the changes according to new Poseidon Str type.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Key Differences from previous processing-instructions PRs:
I have raised issue to poseidon for this: Lack of Support for Logging Messages from console.log to msg! in Poseidon Turbin3/poseidon#26
Raised issue to poseidon for this: Issue: Unused 'info Parameter in Transpiled Anchor Code Turbin3/poseidon#29
Edit- Issue resolved 🚀🚀
Moreover:
added an example for processing-instructions Poseidon program in the /basics/processing-instructions/poseidon directory.
replaced all occurrences of yarn with pnpm to maintain consistency across the project.
executed pnpm fix to ensure code quality.
committed the pnpm-lock.yaml file to the repository.