Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basics/transfer-sol/steel #201

Merged
merged 8 commits into from
Jan 2, 2025
Merged

Conversation

onspeedhp
Copy link
Contributor

No description provided.

@heyAyushh heyAyushh added contribute:steel Adds program example using steel framework. transfer-sol basics/transfrer-sol labels Nov 6, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Before we can merge this PR, please:

  1. Merge main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root to ensure code style consistency
  3. Remove the steel program entry from the root Cargo.toml if present
  4. Run cargo fmt and cargo clippy to ensure Rust code quality
  5. Push your changes

Let me know once you've completed these steps and I'll review again. Thanks!

@onspeedhp
Copy link
Contributor Author

I followed the instructions you told me, but I see a change in the contribution guide, so should I change the script according to the new instructions or leave it as is, but the job check I see something wrong even with hello-solana/steel which I merged from the main branch when building also fails @heyAyushh.

Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyAyushh heyAyushh merged commit adee195 into solana-developers:main Jan 2, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribute:steel Adds program example using steel framework. transfer-sol basics/transfrer-sol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants