UI generate spec for api #1289
Merged
UI generate spec for api #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belfz
reviewed
Aug 23, 2024
belfz
reviewed
Aug 23, 2024
package.json
Outdated
| "start": "yarn watch:openapi", | ||
| "start:frontend": "cd ui && yarn start" | ||
| } | ||
| } |
There was a problem hiding this comment.
TODO do przeniesienia do ui/package.json
belfz
reviewed
Aug 23, 2024
belfz
reviewed
Aug 23, 2024
belfz
reviewed
Aug 23, 2024
…mpatibility issue with CRA
… UserService.test.ts
belfz
reviewed
Aug 26, 2024
| @@ -18,11 +18,14 @@ | |||
| "@types/react-router-bootstrap": "^0.26.6", | |||
| "@types/react-router-dom": "^5.3.3", | |||
| "@types/yup": "^0.32.0", | |||
| "axios": "^1.6.5", | |||
| "axios": "0.27.2", | |||
There was a problem hiding this comment.
I was getting an error like described here: openapistack/openapi-client-axios#172
Turns out, this is an incompatibility issue related to create-react-app.
I had it fixed by downgrading axios' version, as suggested here: facebook/create-react-app#12823 (comment)
In the long run, we might think about migrating this project out of CRA and into Vite-backed codebase, as suggested in the first link.
belfz
reviewed
Aug 26, 2024
| - name: Generate OpenAPI Spec | ||
| id: generate-openapi-spec | ||
| run: sbt "backend/generateOpenAPISpec" | ||
|
|
There was a problem hiding this comment.
before running tests, we need an openapi.yaml file, which is then used to generate proper types (otherwise, tests would fail)
katekozlowska
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.