Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove REAInitializerRCTFabricSurface #6837

Merged
merged 8 commits into from
Jan 13, 2025
Merged

Remove REAInitializerRCTFabricSurface #6837

merged 8 commits into from
Jan 13, 2025

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Dec 19, 2024 •
edited
Loading

Summary

This PR cleans up the Reanimated initialization process for iOS on Fabric. The primary motivation for these changes is to remove REAInitializerRCTFabricSurface, which was used as a workaround to access the surface presenter on the new architecture in bridge-full mode.

⚠️ Please note that this PR drops support for bridge-full mode on the new architecture.

@tomekzaw
Copy link
Member

Finally! 😮

WoLewicki
WoLewicki reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all those other changes done here, are they strictly connected to REAInitializerRCTFabricSurface removal? Or do they remove the bridge path completely? Or is there some other reason?

@piaskowyk
Copy link
Member Author

Why are all those other changes done here, are they strictly connected to REAInitializerRCTFabricSurface removal? Or do they remove the bridge path completely? Or is there some other reason?

@WoLewicki That PR also drops support for bridge-full mode

@piaskowyk piaskowyk added the Check compatibility Trigger a time-consuming compatibility check action label Jan 13, 2025
@piaskowyk piaskowyk marked this pull request as ready for review January 13, 2025 09:31
@piaskowyk
Copy link
Member Author

I've tested it with reloads on both Paper and Fabric, and everything works fine 👍

@piaskowyk piaskowyk enabled auto-merge January 13, 2025 12:11
@piaskowyk piaskowyk added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit b02cdb0 Jan 13, 2025
44 checks passed
@piaskowyk piaskowyk deleted the @piaskowyk/remove-custom-surface branch January 13, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki left review comments

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
Check compatibility Trigger a time-consuming compatibility check action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piaskowyk @tomekzaw @WoLewicki