Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inlined functions profiling #97

Merged
merged 38 commits into from
Jul 1, 2024
Merged

Inlined functions profiling #97

merged 38 commits into from
Jul 1, 2024

Conversation

piotmag769
Copy link
Collaborator

@piotmag769 piotmag769 commented Jun 11, 2024 •
edited
Loading

Closes #81

Introduced changes

  • Flag to add inlined functions to profile
  • Changed the logic of counting steps - now on every pc we add a step to an appropriate call stack. It is needed to unify the logic with inlines - since every statement in a sierra function can have a different original (with inlined functions included) stack

Checklist

  • Linked relevant issue
  • Updated relevant documentation (README.md)
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@piotmag769 piotmag769 changed the base branch from main to build-inlined-functions-in-pprof June 12, 2024 11:18
Base automatically changed from build-inlined-functions-in-pprof to main June 12, 2024 12:59
@piotmag769 piotmag769 marked this pull request as ready for review June 19, 2024 16:51
@piotmag769 piotmag769 requested review from ddoktorski and MaksymilianDemitraszek and removed request for ddoktorski June 19, 2024 16:51
ddoktorski
ddoktorski reviewed Jun 26, 2024
View reviewed changes
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/inlining.rs Outdated Show resolved Hide resolved
ddoktorski
ddoktorski approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@piotmag769 piotmag769 added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 5d1cdcd Jul 1, 2024
4 checks passed
@piotmag769 piotmag769 deleted the inlined-logic branch July 1, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@MaksymilianDemitraszek MaksymilianDemitraszek Awaiting requested review from MaksymilianDemitraszek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inlined functions in function level profiling
2 participants
@piotmag769 @ddoktorski