Refactor in preparation for inlining functions #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotmag769
commented
Jun 7, 2024
piotmag769
commented
Jun 7, 2024
MaksymilianDemitraszek
suggested changes
Jun 10, 2024
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs
Outdated
Show resolved
Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs
Outdated
Show resolved
Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs
Outdated
Show resolved
Hide resolved
MaksymilianDemitraszek
suggested changes
Jun 10, 2024
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs
Outdated
Show resolved
Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder.rs
Outdated
Show resolved
Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs
Outdated
Show resolved
Hide resolved
ddoktorski
reviewed
Jun 10, 2024
MaksymilianDemitraszek
approved these changes
Jun 11, 2024
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs
Outdated
Show resolved
Hide resolved
crates/cairo-profiler/src/trace_reader/function_trace_builder/function_stack_trace.rs
Outdated
Show resolved
Hide resolved
MaksymilianDemitraszek
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #71
Introduced changes
Functionthat will be used to signalise a function was inlinedCompiledArtifactsPathMapEntryPointId(its only purpose was to be converted intoFunctionName, served no purpose)