Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use class hash instead of contract address #82

Open
piotmag769 opened this issue Jun 3, 2024 · 0 comments
Open

Use class hash instead of contract address #82

piotmag769 opened this issue Jun 3, 2024 · 0 comments
Labels
design-doc Requires design doc. input-format Requires changing the input format (and therefore updating integrated tools).

Comments

@piotmag769
Copy link
Collaborator

Contract address is irrelevant for profiling purposes. We should instead display a class hash if the contract name is unknown or the --show-details flag is used. The part of implementation on the side of snforge is related to foundry-rs/starknet-foundry#2058
@piotmag769 piotmag769 added input-format Requires changing the input format (and therefore updating integrated tools). design-doc Requires design doc. labels Jun 3, 2024
@piotmag769 piotmag769 mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design-doc Requires design doc. input-format Requires changing the input format (and therefore updating integrated tools).
Projects
cairo-profiler
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@piotmag769