Added particle labelling to plot.annotate(). #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I notice this could be made more flexible by accepting a string argument for |
| @@ -392,10 +392,10 @@ def plot_traj3d(*args, **kwargs): | |||
| ptraj3d = plot_traj3d | |||
|
|
|||
| @make_axes | |||
| def annotate(centroids, image, circle_size=None, color=None, | |||
| def annotate(centroids, image, circle_size=None, label=False, color=None, | |||
There was a problem hiding this comment.
please put new kwargs at the end of the list (think of the case where someone is using annotate(cent, img, 5, 'b') this is now silently (as in the code runs) but does something different).
|
@hohlraum Are you planning to update the PR? It would be nice to have this addition in the next release. |
|
@hohlraum Any chance you'll be able to revisit this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particles can be automatically laballed by plot.annotate(). Also includes a style dictionary similar to that for the markers and background image.