Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag link functionality #79

Merged
merged 7 commits into from
Aug 18, 2024
Merged

Tag link functionality #79

merged 7 commits into from
Aug 18, 2024

Conversation

TrippBarker
Copy link
Contributor

Adding functionality to tags so when they are clicked they pull up the explore component with a search value.

Explore and NavBar components were using redundant code to search for projects so I extracted the searchProject method from the Explore component and created a new Explore Service so that future Components can use the Service without creating more redundant code.

@cengique
Copy link
Member

@TrippBarker ok, this is cool. But I don't see the "Tag" option in the pull down of the Explore page. Can you make it official in there so that when the filter activates it actually populates the text box with the tag as well?

@TrippBarker
Copy link
Contributor Author

@cengique Do you mean the dropdown with Project and Profile? There is no Tag option there because the tags are used for searching for Projects, so I just have it searching for Projects with the related tag. I did not notice it was not populating the textbox, I will get that working today!

@cengique
Copy link
Member

@cengique Do you mean the dropdown with Project and Profile? There is no Tag option there because the tags are used for searching for Projects, so I just have it searching for Projects with the related tag. I did not notice it was not populating the textbox, I will get that working today!

Yes, that's what I meant! But you're right, it's still searching for projects, so it can stay there. Will you define an "advanced search" syntax then (like on GitHub)?

@TrippBarker
Copy link
Contributor Author

@cengique I certainly can try my hand at making some advance search syntax, that sounds like it will be fun to work out.

Copy link
Member

@cengique cengique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, although it would have been nice to update the search box with the terms

@cengique cengique merged commit d6dfffa into develop Aug 18, 2024
1 check passed
@cengique cengique deleted the tag-link-functionality branch August 21, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants