Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib/decoder): 优化变量名 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickyes
Copy link

@rickyes rickyes commented Oct 24, 2019

const headerLength = type === RpcCommandType.RESPONSE ? 20 : 22;

第一眼看去,以为是header的长度。。。。

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@f54c356). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #9   +/-   ##
=========================================
  Coverage          ?   96.78%           
=========================================
  Files             ?       30           
  Lines             ?      777           
  Branches          ?        0           
=========================================
  Hits              ?      752           
  Misses            ?       25           
  Partials          ?        0
Impacted Files Coverage Δ
lib/decoder.js 92% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54c356...6a9f3c2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants