Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Various changes relative to the constraint matrix #5017

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

alxbilger
Copy link
Contributor

@alxbilger alxbilger commented Sep 24, 2024

  • LinearSolverConstraintCorrection::F is deprecated because it is not used. I believe it stopped to be used here: 50fe60f#diff-b0264445a2a81f648e146f0b1d59d5d197cf3a935f3b7cbb24af11a38b8e6e68L433
  • override keyword was missing in ~LinearSolverConstraintCorrection
  • LinearSolverConstraintCorrection::J is renamed to m_constraintMatrix. Its floating-type is no longer SReal, but Real. In theory, it's breaking.
  • computeJ is no longer used. Instead, I introduce the method convertConstraintMatrix, which is IMO clearer. computeJ could be removed I think. But for some reasons it is virtual. Anyone overrides it?
  • Added a timer in convertConstraintMatrix. This must be used for benchmark to evaluate the cost of the conversion. I believe that we can think of a way to avoid the conversions (only if it costs too much).
  • MatrixLinearSolverInternalData::copyJmatrix is renamed to convertMatrix and it is now protected.
  • Made getLocalJ clearer.
  • Added details for addJMInvJt
  • Introduced rebind types for CompressedRowSparseMatrixConstraint, CompressedRowSparseMatrixGeneric and CompressedRowSparseMatrixMechanical
  • CompressedRowSparseMatrixConstraint: added test for the stream operator. The operator no longer adds trailing spaces on each line.
  • Better iterators in CompressedRowSparseMatrixConstraint
  • Missing header guard in CompressedRowSparseMatrixConstraintEigenUtils.h
  • Fixed operator() in CompressedRowSparseMatrixToEigenSparseVec. Also added error message if out-of-bounds. Required for Access to the constraint matrix SofaPython3#459
  • Introduction of is_specialization_of. Used in a SofaPython3 PR

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: breaking Change possibly inducing a compilation error pr: status to review To notify reviewers to review this pull-request refactoring Refactor code labels Sep 24, 2024
@fredroy
Copy link
Contributor

fredroy commented Sep 25, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot added the pr: highlighted in next release Highlight this contribution in the notes of the upcoming release label Sep 25, 2024
@alxbilger
Copy link
Contributor Author

[ci-build][with-all-tests][force-full-build]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 10, 2024
@fredroy fredroy merged commit 0a8be8e into sofa-framework:master Oct 10, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: breaking Change possibly inducing a compilation error pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants