Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collision.Detection.Intersection] Rename Data #4675

Conversation

lamriaimen
Copy link
Contributor

According to the guidelines


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request refactoring Refactor code pr: clean Cleaning the code labels Apr 23, 2024
@fredroy
Copy link
Contributor

fredroy commented Apr 24, 2024

[ci-build][with-all-tests]

@hugtalbot hugtalbot removed the pr: clean Cleaning the code label Apr 25, 2024
@alxbilger
Copy link
Contributor

[ci-build][with-all-tests][force-full-build]

Copy link
Contributor

@alxbilger alxbilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, check the indentation is consistant

lamriaimen and others added 7 commits April 30, 2024 10:19
…nent/collision/detection/intersection/MinProximityIntersection.h

Co-authored-by: Paul Baksic <[email protected]>
…nent/collision/detection/intersection/LocalMinDistance.h

Co-authored-by: Alex Bilger <[email protected]>
…nent/collision/detection/intersection/LocalMinDistance.h

Co-authored-by: Alex Bilger <[email protected]>
…nent/collision/detection/intersection/MinProximityIntersection.h

Co-authored-by: Paul Baksic <[email protected]>
…nent/collision/detection/intersection/MinProximityIntersection.h

Co-authored-by: Paul Baksic <[email protected]>
@lamriaimen lamriaimen requested review from bakpaul and alxbilger April 30, 2024 12:37
lamriaimen and others added 4 commits May 3, 2024 15:52
…nent/collision/detection/intersection/MinProximityIntersection.cpp

Co-authored-by: Alex Bilger <[email protected]>
…nent/collision/detection/intersection/MinProximityIntersection.cpp

Co-authored-by: Alex Bilger <[email protected]>
@fredroy fredroy merged commit 204a38a into sofa-framework:master May 7, 2024
9 of 11 checks passed
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 7, 2024
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants