Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT remove hacks after some stability issues have been fixed upstream #120

Merged
merged 2 commits into from
Oct 6, 2023
Merged

MNT remove hacks after some stability issues have been fixed upstream #120

merged 2 commits into from
Oct 6, 2023

Conversation

fcharras
Copy link
Collaborator

@fcharras fcharras commented Oct 6, 2023

However, add NUMBA_DPEX_OPT=0 when running tests on CPU

@fcharras
MNT remove hacks after some stability issues have been fixed upstream…
f3a34c4 
…, however add NUMBA_DPEX_OPT=0 when running tests on CPU
ogrisel
ogrisel approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@fcharras
Run tests that require NUMBA_DPEX_OPT>0 in a different bucket than te…
390c1bc 
…sts that require NUMBA_DPEX_OPT=0 + cluster relocation bugfix
@fcharras
Copy link
Collaborator Author

fcharras commented Oct 6, 2023

Alt text

@fcharras fcharras merged commit e7a9c6d into main Oct 6, 2023
2 checks passed
@fcharras fcharras deleted the mnt/fix_stability_issues branch October 6, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcharras @ogrisel