run time & memory table to graph ⚙️ #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myungkim930
reviewed
Jul 17, 2024
There was a problem hiding this comment.
I tried to test the new code on the wina_pl example and I ran into few problems:
- When I ran the example, I saw that the results were different. When looking at the constructed data (on the wina_pl example) I found that the new code did not include the ABV variable. I think there is a mix up since ABV is being lower-cased.
- When I ran the example only with numerical variables, it gave me the error.
Thank you!
myungkim930
reviewed
Jul 17, 2024
| if num_cat != 0: | ||
| data_cat = data_cat.str.replace("\n", " ", regex=True).str.lower() | ||
| data_num = X_numerical.iloc[idx] | ||
| data_cat = data_cat.dropna().str.lower() |
There was a problem hiding this comment.
It gives an error here when we only have datasets with numerical features
myungkim930
reviewed
Jul 17, 2024
| if self.is_fitted_ == False: | ||
| self.is_fitted_ = True | ||
| if self.num_col_names: | ||
| num_cols_exist = [col for col in self.num_col_names if col in X.columns] |
There was a problem hiding this comment.
the num_col_exist does not contain the ABV variable (for the wina_pl example), causing different results. I think there is a mix-up between the lower- and upper-cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jun,
Best,
Gaëtan