Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to using cowboy 0.9.0 #59

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

myers
Copy link
Contributor

@myers myers commented Feb 12, 2014

This upgrades the dependencies to cowboy 0.9.0

@majek
Copy link
Member

majek commented Feb 13, 2014

weren't there any major API changes between cowboy 0.8.3 and 0.9? I thought there were.

@myers
Copy link
Contributor Author

myers commented Feb 13, 2014

It worked fine for me in the Elixir sample apps I was building, but your question made me go back and check the example apps in this repo. I fixed them so they run again.

@majek
Copy link
Member

majek commented Feb 13, 2014

Have you tried running sockjs-protocol tests against the server?

@myers
Copy link
Contributor Author

myers commented Feb 13, 2014

I've been yak shaving all morning to get the sockjs-protocol tests to run for me. I can't get master of sockjs-protocol to run against master of sockjs-erlang without error. I get the same set of errors with my branch.

Many of the errors seem to say that I don't have the right versions of the 3rd party python modules they use.

I don't know if you have any say over some of the pull requests on that repo, but sockjs/sockjs-protocol#70 looks it's moving in the right direction for that by adding a 'requirements.txt' file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants