Windows: Fix build error incompatible pointer types #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GitHub workflows, building the native extensions for
cool.io
fails as follows:ruby/setup-ruby v1
to set up Rubycool.io
v1.8.0I have tested this by enabling Windows CI on my fork.
You can see this error occurs on Windows:
In addition, I have made the test repository that depends on
cool.io
.You can check this error here too:
About this fix
The type of
buf
member ofWSABUF
ischar *
:On
libev
upstream, this was already fixed on v4.25:http://cvs.schmorp.de/libev/ev.c?r1=1.484&r2=1.485&pathrev=rel-4_25
Maybe we should try to update the overall
libev
version, but that could be difficult.This PR intends to fix this error first.
Types of Changes
Contribution