-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add listing of all open pull requests sorted by open time #253
base: v0.x.x
Are you sure you want to change the base?
Add listing of all open pull requests sorted by open time #253
Conversation
This adds the skeleton to build the empty application called time_open. The purpose of the application is to list latest open pull requests for a repository.
cfbf74b
to
b6f5c85
Compare
@shiv-tiwari-dunnhumby This is the tool we talked about. Please have a look. |
src/time_open/main.d
Outdated
|
||
*******************************************************************************/ | ||
|
||
version(unittest) {} else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a bad idea. When make unittest
is done, there will be 2 main
and the linker will complain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused I just copied from src/autopr/main.d
. Why will there be two main
s? Doesn't this only add the main, when you are not in a unittest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed code in a fixup commit to add an empty main for unittest
s. I'm still puzzled because the other tools don't need it.
@leandro-lucarella-sociomantic Any idea why the build is failing? I didn't change dub dependencies. |
b6f5c85
to
8785bb3
Compare
This implements the command `time_open`. It will output the list of open pull requests for a repository sorted by open time. This is implemented by performing a GraphQL query against the GitHub API service and sorting the output.
8785bb3
to
2d9c31b
Compare
The latest dyaml |
No idea. |
This implements the command
time_open
. It will output the list of openpull requests for a repository sorted by open time. This is implemented
by performing a GraphQL query against the GitHub API service and sorting
the output.