-
-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Apply suggestions from code review by @ibucklaw
Co-authored-by: Iain Buclaw <[email protected]>
- Loading branch information
Showing
1 changed file
with
5 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
### The `setup` comman will not attempt to login using user/password | ||
### The `setup` command will not attempt to login using user/password | ||
|
||
GitHub stopped supporting login using user/password with the API, so trying to | ||
GitHub stopped supporting logins using user/password with the API, so trying to | ||
do so in the `setup` command is doomed to fail. Because of this, support for | ||
generating a Personal Access Token (PAT) for the user is now removed. Instead | ||
the user has to create their own PAT manually and passing it to the `setup` | ||
the user has to create their own PAT manually and pass it to the `setup` | ||
command instead. | ||
|
||
In particular the `setup` command removed the `--password` option and added | ||
a `--oauthtoken` option instead, and when not specified, it will ask the user | ||
the `--oauthtoken` option instead, and when not specified, it will ask the user | ||
to create one (with some hints on how to do so). | ||
|
||
**NOTE:** This would normally be a breaking change deserving a new major, but | ||
**NOTE:** This would normally be a breaking change deserving a new major release, but | ||
since the tool was *externally* broken, there is no way to fix it without | ||
breaking changes and previous versions will be **all broken**, so it doesn't | ||
make sense to make a major release for this change. |