-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Enter the homepage immediately after signing up #576
Open
badukwei
wants to merge
3
commits into
main
Choose a base branch
from
remove-protectedRoute
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+290
−142
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export const AUTH_ERROR_MESSAGE = { | ||
DEFAULT: '很抱歉通知您,您尚未登陸帳號,請返回註冊頁再次嘗試註冊,謝謝您!', | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 11 additions & 1 deletion
12
packages/frontend/src/features/auth/components/ErrorDialog/ErrorDialog.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,21 @@ | ||
import AuthErrorDialog from '@/features/auth/components/AuthErrorDialog/AuthErrorDialog' | ||
import { useAuthStatus } from '@/features/auth/hooks/useAuthStatus/useAuthStatus' | ||
import { useNavigate } from 'react-router-dom' | ||
|
||
export default function ErrorDialog() { | ||
const { signupErrors } = useAuthStatus() | ||
const isError = signupErrors.some((error) => !!error) | ||
const navigate = useNavigate() | ||
|
||
const handleClose = () => { | ||
navigate('/welcome') | ||
} | ||
|
||
return ( | ||
<AuthErrorDialog isOpen={isError} message={signupErrors[0]?.message} /> | ||
<AuthErrorDialog | ||
isOpen={isError} | ||
message={signupErrors[0]?.message} | ||
onClose={handleClose} | ||
/> | ||
) | ||
} |
58 changes: 0 additions & 58 deletions
58
packages/frontend/src/features/auth/components/ProtectedRoute/ProtectedRoute.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
packages/frontend/src/features/auth/hooks/useAuthCheck/useAuthCheck.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { useAuthStatus } from '@/features/auth' | ||
import { useAuthStore } from '../../stores/authStore' | ||
|
||
type CallbackFunction = () => void | ||
|
||
export function useAuthCheck(errorMessage: string) { | ||
const { isLoggedIn } = useAuthStatus() | ||
const setErrorMessage = useAuthStore((state) => state.setErrorMessage) | ||
|
||
const checkAuth = (callback: CallbackFunction) => { | ||
if (!isLoggedIn) { | ||
setErrorMessage(errorMessage) | ||
} else { | ||
callback() | ||
} | ||
} | ||
|
||
return checkAuth | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
packages/frontend/src/features/auth/provider/AuthProvider.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import React from 'react' | ||
import { useAuthStore } from '../stores/authStore' | ||
import AuthErrorDialog from '../components/AuthErrorDialog/AuthErrorDialog' | ||
|
||
const AuthProvider: React.FC<{ children: React.ReactNode }> = ({ | ||
children, | ||
}) => { | ||
const { errorMessage, setErrorMessage } = useAuthStore() | ||
|
||
return ( | ||
<> | ||
{children} | ||
{errorMessage && ( | ||
<AuthErrorDialog | ||
isOpen={!!errorMessage} | ||
message={errorMessage} | ||
onClose={() => setErrorMessage(null)} | ||
/> | ||
)} | ||
</> | ||
) | ||
} | ||
|
||
export default AuthProvider |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import create from 'zustand' | ||
|
||
type AuthStore = { | ||
errorMessage: string | null | ||
setErrorMessage: (message: string | null) => void | ||
} | ||
|
||
export const useAuthStore = create<AuthStore>((set) => ({ | ||
errorMessage: null, | ||
setErrorMessage: (message) => set({ errorMessage: message }), | ||
})) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to refactor this codes in the more modern style such as async/await.