Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Reallocate switches #779

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

kylerisse
Copy link
Member

Fixed #775

Description of PR

This is a mass renaming of all the switches per work party 1. It also disables the data validation for switch noise level as that will be going away.

Previous Behavior

  • switches had previous IDs
  • noise level data validation only allowed for specific values

New Behavior

  • switches have new IDs supplied by @davidelang
  • noise level data validation now passes with any value, no longer strict

Tests

  1. spot checked a couple of entries in the output
  2. ran nix build -L .#checks.x86_64-linux.pytest-facts to validate TSV contents still valid (found noise level issue and modified behavior.
  3. ran nix build -L .#checks.x86_64-linux.perl-switches and verified the switch configurations were generated and script exit 0
  4. Asking @davidelang to check this PR and approve if it all looks good.

@davidelang
Copy link
Collaborator

@owendelong this looks good to me. There are two switches we need to replace #5 and #51 (formerly #54)
I think you probably want to set some default configs for the spares, but I don't know what you would want to do with them (1/2 for rooms for each side? set some as idf or booth? don't care because you will reassign them when they go to get used??)

@owendelong
Copy link
Collaborator

I had previously set them all up as cfRoom just as a placeholder and to minimize the likelihood of conflict if they got plugged in to a switch port in the NOC.

Copy link
Collaborator

@owendelong owendelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On cursory look, this seems sane. We should be prepared for "interesting" flash results.

I'll try to catch anything glaring during the sticker generation process on its next run.

@owendelong owendelong merged commit 1d68dd5 into socallinuxexpo:master Sep 22, 2024
14 checks passed
@davidelang
Copy link
Collaborator

davidelang commented Sep 22, 2024 via email

@kylerisse kylerisse deleted the reorg_switch_data_files branch September 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reallocate switches
3 participants