[READY] - Belkin RT3200 support for scale openwrt #611

sarcasticadmin · 2023-08-08T01:00:50Z

Description of PR

I wanted to get this to a place where it was workable before it got any larger. But this adds support for a new piece of hardware: Belkin RT3200/linksys (https://openwrt.org/toh/linksys/e8450)

There are some known issues with whats here but Ill clean that up in follow up PRs, mainly:

Disable logd
Add back the backdoor network interface for the new mt-7622 hardware
disable conntrack and netfilter modules
Enable MIMO hardware offloading on belkin 3200
Supporting new htmode for wifi channel allocation (AX modes specifically)? however, after reviewing the docs we might just wanted to leave this in a general sweet spot: https://openwrt.org/docs/guide-user/network/wifi/basic#htmodewi-fi_channel_width
Enable radio3 for wifi6

Each of these items has been spun out as an issue in our backlog

Previous Behavior

Only supported 2 APs architectures
Weekly build of ar71xx, ipq806x
Openwrt configs were built with the default being ar71xx

New Behavior

Support for 3 AP architectures: ar71xx, mt-7622, ipq806x (technically 4 with x86_64 as well but we dont run that on hardware)
Default openwrt config leverages neutral x86_64 architecture so no architecture/hardware specific packages are pulled in. We will now default to leveraging x64_64 when building common.config for openwrt.
Leveraging architecture specific files-<arch> dir to overlay config after files templating. This provides a much clearer way to place architecture specific configuration instead of if, elif, ... in the go templates
DSA configuration for mt-7622
Weekly build of: ar71xx, mt-7622
Move ar71xx specific configuration (wired, wireless) to its own files-ar71xx folder
Disable golden tests for ipq806x since we will not be investing any additional effort into that architecture

Tests

DSA network configuration was tested on the mgmt interface for both vlan 103 & 503
brctl show, confirming STP enabled on all interfaces:

# brctl show
bridge name     bridge id               STP enabled     interfaces
scaleslow-br            7fff.e89f80e7f941       yes             br-lan.500
                                                        br-lan.100
br-lan          7fff.e89f80e7f941       yes             lan4
                                                        lan2
                                                        wan
                                                        lan3
                                                        lan1
mgmt-br         7fff.e89f80e7f941       yes             br-lan.503
                                                        br-lan.103
scalefast-br            7fff.e89f80e7f941       yes             br-lan.501
                                                        br-lan.101

note spanning tree (STP) is enabled

Tested the uptime with real traffic for the last ~4 days. Looks stable:

# uptime
 08:39:56 up 4 days,  3:49,  load average: 0.14, 0.04, 0.01

CI image build results: https://github.com/socallinuxexpo/scale-network/actions/runs/5946721473

sarcasticadmin · 2023-08-08T01:35:22Z

openwrt/configs/common.config

 CONFIG_PACKAGE_openssh-client=y
 CONFIG_PACKAGE_openssh-client-utils=y
 CONFIG_PACKAGE_openssh-keygen=y
 CONFIG_PACKAGE_openssh-server=y
-CONFIG_PACKAGE_python3-base=y


removing python3 since we dont currently rely on it for anything

Uh, shouldn't we be going the other way... Deprecating Python2 and migrating all our dependencies to Python3?

this only pertains to python3 on the openwrt image. I opted to remove it since we dont currently have any python scripts installed on the APs. So we wont have python3 or python2 on the APs so we save the build time and the space on the image

good riddance!

sarcasticadmin · 2023-08-08T01:36:08Z

openwrt/configs/common.config

 CONFIG_PACKAGE_jq=y
-CONFIG_PACKAGE_kmod-ipt-core=y
-CONFIG_PACKAGE_kmod-nf-ipt=y
-CONFIG_PACKAGE_kmod-usb-serial=y


Some of these kernel modules were for serial connectivity, but arent used since we just use the serial pins on the board instead of a dedicated usb device

makes sense

sarcasticadmin · 2023-08-08T01:36:38Z

openwrt/configs/common.config

 CONFIG_PACKAGE_lldpd=y
-# CONFIG_PACKAGE_logd is not set


will add this back in a follow up PR

sarcasticadmin · 2023-08-08T02:11:39Z

openwrt/files-mt7622/etc/config/network.0

@@ -0,0 +1,111 @@
+config interface 'loopback'


Im opting to embed the configs for the network and the wireless vs template them. I dont think contorting the existing config is worth it given how static this typically is. Open to ideas here

I really don't understand the need for a ula_prefix in OpenWRT. If we can avoid it, I'd rather do so. We have no use for ULA in our environment. OTOH, it seems that OpenWRT may perhaps break badly without one for reasons utterly passing understanding. I haven't had time to dig into this and/or rant about it upstream, but if you can look at that and provide some feedback, that would be appreciated.

thanks for the catch @owendelong This was just a carrier over from the default auto gen config from openwrt. Removing it doesnt break anything from my testing.

It comes from the uci defaults: https://github.com/openwrt/openwrt/blob/master/package/base-files/files/etc/uci-defaults/12_network-generate-ula but why thats a default I dont know either.

owendelong · 2023-08-09T00:57:52Z

openwrt/configs/x86-generic.config

Do we really want to build x86 targets? For what?

Youre right and we wont be using the target on any deployment but I briefly touched on it in the PR description:

Default openwrt config leverages neutral x86_64 architecture so no architecture/hardware specific packages are pulled in. We will now default to leveraging x64_64 when building common.config for openwrt.

In order to do multiple architectures in openwrt I have to start with a base config which needs an architecture. It autoselects one if I dont have any defined. x86 is a neutral architecture so we dont get any specific architecture or model packages. Theres no other way to filter them out either. If anyone else has better ideas how to do this Im all ears.

So instead the idea is to do the following order of operations to generate our configurations across N architectures:

1. Generate a common.config using the x86 architecture since it omits any specific architecture packages. All packages declared here should be hardware independent and common across any architecture in scales environment. 2. For new architectures generate a $TARGET-generic.config without including any common config. 3. Combine $TARGET-generic.config + common.config and tweak until it includes all desired configuration. Output this the $TARGET-generic.config. This will include all CONFIG_TARGET config and architecture specific packages

Previously we were diffing the configs based on the prefixes of the build option names. Anything with that included CONFIG_TARGET was target specific, while everything else was common. This no longer works since there are many packages that exist specifically for a given arch/model and are not prefixed with CONFIG_TARGET.

owendelong

I've provided individual comments inline, but generally looks good. Excellent effort, Rob.

Finally getting support for the belkin RT3200

The assumption is that we are using bash by default. For some reason ubuntu still can inherit sh. Instead of assuming well be explicit about which SHELL we expect.

Previously we were diffing the configs based on the prefixes of the option names. Anything with that included CONFIG_TARGET was target specific, while everything else was common. This no longer works since there are many packages that exist specifically for a given arch and are not prefixed with CONFIG_TARGET. So instead the idea is to do the following order of operations to generate our configurations across N architectures: 1. Generate a common.config using the x86 architecture since it omits any specific architecture packages. All packages declared here should be hardware independent and common across any architecture in scales environment. 2. For new architectures generate a $TARGET-generic.config without including any common config. 3. Combine $TARGET-generic.config + common.config and tweak until it includes all desired configuration. Output this the $TARGET-generic.config. This will include all CONFIG_TARGET config and architecture specific packages.

Not all architectures have "generic" in their output paths for build artifacts. Especially the mt7622 builds.

we dont currently use the build for ipq806x so Id prefer to disable this in favor of the new mt7622 build (belkin RT3200)

Adding notes about new workflow for the openwrt build configs and some notes about doing it manually. Since you typically have to do this when adding a new board or cleaning out the existing config files.

sarcasticadmin · 2023-08-09T20:53:39Z

@owendelong thanks for the review and the feedback! If you need any more clarification you know where to find me!

kylerisse

@sarcasticadmin this all makes sense logically. As discussed, I didn't run through full test as I more than trust your methodology, and as you stated it's best to get this moving now since its getting beefy, and continue to iterate. Very cool idea to default to the common architecture and leverage arch specific configs. 🚢

kylerisse · 2023-08-19T18:28:37Z

openwrt/Makefile

 	cat ./$(BUILD_DIR)/$(IMAGEBUILDER)/.diffconfig | grep -v CONFIG_TARGET > ./configs/common.config

 targetconfig: diffconfig
-	cat ./$(BUILD_DIR)/$(IMAGEBUILDER)/.diffconfig | grep CONFIG_TARGET > ./configs/$(TARGET)-generic.config
+	comm -23 <(sort ./$(BUILD_DIR)/$(IMAGEBUILDER)/.diffconfig) <(sort ./configs/common.config) > ./configs/$(TARGET)-generic.config


comm, nice!

kylerisse · 2023-08-19T18:29:43Z

openwrt/configs/common.config

 CONFIG_PACKAGE_jq=y
-CONFIG_PACKAGE_kmod-ipt-core=y
-CONFIG_PACKAGE_kmod-nf-ipt=y
-CONFIG_PACKAGE_kmod-usb-serial=y


makes sense

kylerisse · 2023-08-19T18:30:43Z

openwrt/configs/common.config

 CONFIG_PACKAGE_openssh-client=y
 CONFIG_PACKAGE_openssh-client-utils=y
 CONFIG_PACKAGE_openssh-keygen=y
 CONFIG_PACKAGE_openssh-server=y
-CONFIG_PACKAGE_python3-base=y


good riddance!

kylerisse · 2023-08-19T18:31:25Z

openwrt/configs/mt7622-generic.config

@@ -0,0 +1,25 @@
+# CONFIG_PACKAGE_kmod-ata-ahci-mtk is not set


Thanks for marking all the not set features. This really helps somebody unfamiliar with all the bells and whistles like me understand what's going on.

kylerisse · 2023-08-19T18:33:23Z

openwrt/docs/BUILD.md

+```
+> Assuming mt7622 is our target arch
+
+Thats it now you should have a generic config and a arch specific config going forward. The majority of these steps are taken care of by the Makefile in the `openwrt` dir but in the cases where


nice, seems like a clean setup

facts/secrets/mt7622-openwrt-example.yaml

sarcasticadmin · 2023-08-21T14:08:18Z

Thanks @kylerisse for your review, Ill make the small tweaks and then report back when its pushed up

sarcasticadmin · 2023-08-23T03:04:46Z

@owendelong @kylerisse Marking this as ready! Thanks again for the feedback and review. Ive spun out some additional items to address with this hardware after we get this initial set of changes merged.

the ipq806x based AP (tplink) is on its way out. We found the drivers to unstable after many years of waiting. Well be moving onward to the mt7622 and belkin/linksys hardware instead.

owendelong

Looks good to me. Excellent work, Rob.

sarcasticadmin changed the title ~~[REVIEW] - Belkin 3200 support for scale openwrt~~ [REVIEW] - Belkin RT3200 support for scale openwrt Aug 8, 2023

sarcasticadmin mentioned this pull request Aug 8, 2023

[READY] - Bump alpine container for golden tests #612

Merged

sarcasticadmin commented Aug 8, 2023

View reviewed changes

sarcasticadmin force-pushed the rh/issue-367 branch from 57549f6 to dfddc55 Compare August 8, 2023 02:04

sarcasticadmin commented Aug 8, 2023

View reviewed changes

sarcasticadmin requested review from owendelong, davidelang and kylerisse August 8, 2023 02:14

sarcasticadmin force-pushed the rh/issue-367 branch 3 times, most recently from c44e1d2 to 6a6e631 Compare August 8, 2023 03:05

owendelong reviewed Aug 9, 2023

View reviewed changes

sarcasticadmin added 4 commits August 9, 2023 20:12

from scratch rebuild of common.config

aa77e92

baseline mt7622 config

6a33198

Finally getting support for the belkin RT3200

default openwrt make SHELL to bash

a714925

The assumption is that we are using bash by default. For some reason ubuntu still can inherit sh. Instead of assuming well be explicit about which SHELL we expect.

init x86-generic.config

75cab92

sarcasticadmin force-pushed the rh/issue-367 branch 2 times, most recently from a9929ea to bfb3f29 Compare August 9, 2023 20:37

sarcasticadmin added 4 commits August 9, 2023 20:50

dont assume path during openwrt make package

9b3d92d

Not all architectures have "generic" in their output paths for build artifacts. Especially the mt7622 builds.

enable mt7622 in gh matrices

ca4010a

we dont currently use the build for ipq806x so Id prefer to disable this in favor of the new mt7622 build (belkin RT3200)

doc updates for openwrt BUILD.md

603bcab

Adding notes about new workflow for the openwrt build configs and some notes about doing it manually. Since you typically have to do this when adding a new board or cleaning out the existing config files.

sarcasticadmin force-pushed the rh/issue-367 branch from bfb3f29 to 2fa0039 Compare August 9, 2023 20:50

sarcasticadmin requested a review from owendelong August 9, 2023 20:54

kylerisse approved these changes Aug 19, 2023

View reviewed changes

sarcasticadmin added 2 commits August 23, 2023 02:46

init example mt7622 openwrt facts

acde699

support TARGET specific file for openwrt

9569fe4

init specific files for mt7622 arch

5dcefbc

sarcasticadmin force-pushed the rh/issue-367 branch from 2fa0039 to 5dcefbc Compare August 23, 2023 02:47

This was referenced Aug 23, 2023

disable logd in openwrt builds #613

Closed

Add backdoor interface for debugging on mt-7622 #614

Open

disable conntrack and netfilter modules in openwrt builds #615

Open

Enable wifi6 and mimo features on mt-7622/belkin hardware #616

Open

sarcasticadmin changed the title ~~[REVIEW] - Belkin RT3200 support for scale openwrt~~ [READY] - Belkin RT3200 support for scale openwrt Aug 23, 2023

sarcasticadmin added 3 commits August 23, 2023 03:32

support ar71xx specific openwrt files

f39f2ba

support arch specific files dir in golden tests

661756b

remove support for ipq806x golden tests

c208d55

the ipq806x based AP (tplink) is on its way out. We found the drivers to unstable after many years of waiting. Well be moving onward to the mt7622 and belkin/linksys hardware instead.

owendelong approved these changes Aug 24, 2023

View reviewed changes

owendelong merged commit 81faac3 into master Aug 24, 2023
7 checks passed

owendelong deleted the rh/issue-367 branch August 24, 2023 17:10

nixinator mentioned this pull request Sep 9, 2023

Nix openwrt builder (uses upstream buildimage from openwrt) #617

Open

This was referenced Nov 8, 2023

[READY] - gha: removing set-output due to deprecation #629

Merged

Belkin RT3200 (Linksys E8450) OpenWrt conversion #532

Closed

sarcasticadmin mentioned this pull request Nov 28, 2023

[READY] - Belkin/Linksys UBI support and Openwrt version bump #637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[READY] - Belkin RT3200 support for scale openwrt #611

[READY] - Belkin RT3200 support for scale openwrt #611

sarcasticadmin commented Aug 8, 2023 •

edited

Loading

sarcasticadmin Aug 8, 2023

owendelong Aug 9, 2023

sarcasticadmin Aug 9, 2023

kylerisse Aug 19, 2023

sarcasticadmin Aug 8, 2023

kylerisse Aug 19, 2023

sarcasticadmin Aug 8, 2023

sarcasticadmin Aug 8, 2023

owendelong Aug 9, 2023

sarcasticadmin Aug 9, 2023

owendelong Aug 9, 2023

sarcasticadmin Aug 9, 2023

owendelong left a comment

sarcasticadmin commented Aug 9, 2023

kylerisse left a comment

kylerisse Aug 19, 2023

kylerisse Aug 19, 2023

kylerisse Aug 19, 2023

kylerisse Aug 19, 2023

kylerisse Aug 19, 2023

sarcasticadmin commented Aug 21, 2023 •

edited

Loading

sarcasticadmin commented Aug 23, 2023

owendelong left a comment

		@@ -0,0 +1,25 @@
		# CONFIG_PACKAGE_kmod-ata-ahci-mtk is not set

[READY] - Belkin RT3200 support for scale openwrt #611

[READY] - Belkin RT3200 support for scale openwrt #611

Conversation

sarcasticadmin commented Aug 8, 2023 • edited Loading

Description of PR

Previous Behavior

New Behavior

Tests

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

owendelong left a comment

Choose a reason for hiding this comment

sarcasticadmin commented Aug 9, 2023

kylerisse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sarcasticadmin commented Aug 21, 2023 • edited Loading

sarcasticadmin commented Aug 23, 2023

owendelong left a comment

Choose a reason for hiding this comment

sarcasticadmin commented Aug 8, 2023 •

edited

Loading

sarcasticadmin commented Aug 21, 2023 •

edited

Loading