Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add files via upload #16

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Conversation

Thanhson89
Copy link

Adding comments to code and relu activator function

@monadius monadius self-assigned this Jul 7, 2019
@monadius
Copy link
Member

monadius commented Jul 7, 2019

Please delete all binary files from this PR (*.cmo, *.cmi, etc.)

@monadius monadius self-requested a review July 14, 2019 04:41
Copy link
Member

@monadius monadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only files const.ml, eval.ml, and expr.ml (without relu) may be merged to the develop branch. Please edit these files and remove all other files.

Other files (excluding all binary files) should be placed in a separate branch (called relu or something else). My main concern is the changes in input_parse_env.ml which break the specification of rounding in FPTaylor.

type t = Rat of num | Interval of interval

(*
input: num
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of writing input and output, it is better to add explicit type signatures:

let of_num (n : num) : t = ...

const.ml Outdated
(*
input: num
output: t
description: cover num to constrant (t type)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cover -> converts
constrant -> constant
Also make these changes in other places.

default.cfg Outdated Show resolved Hide resolved
default.cfg Outdated Show resolved Hide resolved
eval.ml Outdated
(*
input: string->float
output: float
description: estimate an expression and return a float value, the first argument is a function which return the value (float) of a variable's name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to write: evaluates an expression.

(*
input: no
output: no
description: general type of binary operators and double variable functions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double -> two

expr.ml Outdated
(*
input:
output:
description:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are general multivariate operators and functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants